Skip to content

Fixing doc build workflow #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Mar 22, 2022

Stack from ghstack:

Fixing the issue mentioned here.

I have ran it on my fork and the build worked:
https://github.com/NivekT/data/actions/runs/2023027716

Differential Revision: D35048050

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Mar 22, 2022
ghstack-source-id: f61034a
Pull Request resolved: #314
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2022
@NivekT NivekT requested a review from ejguan March 22, 2022 14:40
@NivekT
Copy link
Contributor Author

NivekT commented Mar 22, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. A nit comment to make this workflow better.

Comment on lines 23 to 24
python3 -m pip install -r https://raw.githubusercontent.com/pytorch/data/main/requirements.txt
python3 -m pip install --no-build-isolation git+https://github.com/pytorch/data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a separate step to compile torchdata from local source as we have a prior step which has already checked out torchdata repo.

python3 -m pip install -r requirements.txt
python3 setup.py install

Fixing the issue [mentioned here](#290 (comment)).

I have ran it on my fork and the build worked:
https://github.com/NivekT/data/actions/runs/2023027716

Differential Revision: [D35048050](https://our.internmc.facebook.com/intern/diff/D35048050)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Mar 22, 2022
ghstack-source-id: f807d07
Pull Request resolved: #314
@NivekT
Copy link
Contributor Author

NivekT commented Mar 22, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants